Talk:GEN

From OHRRPGCE-Wiki
Jump to: navigation, search

S'orlok Reaves: I've noticed some things, but I want to run them by you all before messing up the wiki again. ;) First: All the entries in GEN are INTs, right? This should be mentioned, as I used to think they were bytes. Second, "genMaxMap" should not read "number of maps", but "id of the last map" or "number of maps -1", since a genMaxMap value of 8 implies 9 maps. Shall I change this?

NeoTA: Interesting. The statement about gen() being an array of INTs certainly used to be present. It must have been wiped by an overzealous update. Go ahead. Re: genMaxMap: Crossreferencing with other docs, yes, go ahead and fix that too, it seems that the description is what is wrong rather than name.

S'orlok Reaves: I've updated the page to follow the format of virtually every other lump description by including a "Data" column. I was just going to say "they're all INTs", but for some data (i.e., the 3rd-level passwords) it makes more sense to say 17+1BYTEs than it does 9INTs - 1 BYTE trash. If you disagree, feel free to revert my changes. I also fixed the genMaxMap thing...

NeoTA: Yeh, it's messy either way you write it, I'm glad that kind of weirdness is relatively rare in the OHR format. Personally, I would have written '18 BYTEs' and left the description to specify the unused byte.

Ichiro (talk): Shouldn't we include hex offsets in this page?

Bob the Hamster (talk) 07:16, 30 August 2016 (PDT): If you want to add a column for hex offsets, I have no objection. It would just be the offset column, multiplied by 2, and converted to hex notation. Nothing in the source code ever uses hex notation, but I suppose it could be useful for people using hex editors.